Skip to content

Conversation

@gisellerosetta
Copy link
Contributor

Proposed Changes

  • Removes deprecation notice for the contentsheet attribute in write_workbook()
  • Tests pass locally and I don't think it should break anything based on where else it appears appears.

Related Issues

Pre-requisites

This section may not be fully required if the branch is not merging into main.
Please indicate items that aren't necessary and why, with comments around incomplete checks.

  • Version number has been incremented, according to SemVer NA
  • Changelog has been updated, listing changes to this version. Use the keep a changelog format
  • New features are tested
  • New features are documented using the numpydoc docstring format NA
  • Other relevant package documentation is updated
  • For new functionality, examples are included in the docs or a feature request has
    been made for it/them. NA

@gisellerosetta gisellerosetta self-assigned this Oct 16, 2025
@gisellerosetta gisellerosetta marked this pull request as ready for review October 16, 2025 14:59
@gisellerosetta gisellerosetta linked an issue Oct 16, 2025 that may be closed by this pull request
4 tasks
@ellie-o ellie-o requested review from ldavies99 and removed request for giuliag92 October 29, 2025 10:22
Copy link
Contributor

@ldavies99 ldavies99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and tests pass. Happy for this to merge.

@ldavies99 ldavies99 merged commit d862584 into dev Nov 3, 2025
11 of 12 checks passed
@ldavies99 ldavies99 deleted the deprecate-contentsheet branch November 3, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate contentsheet

3 participants